Browse Source

User can remove pic from an issue

pull/37/head
Nafies Luthfi 7 years ago
parent
commit
fe3da97edf
  1. 6
      app/Http/Controllers/Issues/PicController.php
  2. 1
      resources/lang/de/issue.php
  3. 1
      resources/lang/en/issue.php
  4. 1
      resources/lang/id/issue.php
  5. 20
      tests/Feature/Projects/ProjectIssuesTest.php

6
app/Http/Controllers/Issues/PicController.php

@ -16,7 +16,11 @@ class PicController extends Controller
$issue->pic_id = $picData['pic_id']; $issue->pic_id = $picData['pic_id'];
$issue->save(); $issue->save();
flash(__('issue.pic_assigned'), 'success');
if ($issue->pic_id) {
flash(__('issue.pic_assigned'), 'success');
} else {
flash(__('issue.pic_removed'), 'warning');
}
return back(); return back();
} }

1
resources/lang/de/issue.php

@ -29,6 +29,7 @@ return [
'assign_pic' => 'Assign PIC', 'assign_pic' => 'Assign PIC',
'select_pic' => 'Select a PIC', 'select_pic' => 'Select a PIC',
'pic_assigned' => 'Issue PIC has been assigned.', 'pic_assigned' => 'Issue PIC has been assigned.',
'pic_removed' => 'Issue PIC has been removed.',
// Attributes // Attributes
'title' => 'Issue Title', 'title' => 'Issue Title',

1
resources/lang/en/issue.php

@ -29,6 +29,7 @@ return [
'assign_pic' => 'Assign PIC', 'assign_pic' => 'Assign PIC',
'select_pic' => 'Select a PIC', 'select_pic' => 'Select a PIC',
'pic_assigned' => 'Issue PIC has been assigned.', 'pic_assigned' => 'Issue PIC has been assigned.',
'pic_removed' => 'Issue PIC has been removed.',
// Attributes // Attributes
'title' => 'Issue Title', 'title' => 'Issue Title',

1
resources/lang/id/issue.php

@ -29,6 +29,7 @@ return [
'assign_pic' => 'Tugaskan PIC', 'assign_pic' => 'Tugaskan PIC',
'select_pic' => 'Pilih PIC', 'select_pic' => 'Pilih PIC',
'pic_assigned' => 'PIC telah ditugaskan.', 'pic_assigned' => 'PIC telah ditugaskan.',
'pic_removed' => 'PIC telah dihapus.',
// Attributes // Attributes
'title' => 'Judul Issue', 'title' => 'Judul Issue',

20
tests/Feature/Projects/ProjectIssuesTest.php

@ -146,4 +146,24 @@ class ProjectIssuesTest extends TestCase
'pic_id' => $worker->id, 'pic_id' => $worker->id,
]); ]);
} }
/** @test */
public function user_can_remove_pic_assignment()
{
$this->adminUserSigningIn();
$worker = $this->createUser('worker');
$issue = factory(Issue::class)->create(['pic_id' => $worker->id]);
$this->visitRoute('projects.issues.show', [$issue->project, $issue]);
$this->submitForm(__('issue.assign_pic'), [
'pic_id' => null,
]);
$this->seeRouteIs('projects.issues.show', [$issue->project, $issue]);
$this->seeText(__('issue.pic_removed'));
$this->seeInDatabase('issues', [
'id' => $issue->id,
'pic_id' => null,
]);
}
} }
Loading…
Cancel
Save