Refactor site option feature, remove option repo and request class

app/Entities/Options/OptionsRepository.php

@@ -1,38 +0,0 @@
-<?php
-
-namespace App\Entities\Options;
-
-use App\Entities\BaseRepository;
-use App\Exceptions\OptionNotFoundException;
-use App\Exceptions\OptionUpdateException;
-use App\Exceptions\OptionDeleteException;
-
-/**
-* Options Repository Class
-*/
-class OptionsRepository extends BaseRepository
-{
-    protected $model;
-
-    public function __construct(Option $model)
-    {
-        parent::__construct($model);
-    }
-
-    public function getAll($q = null)
-    {
-        return Option::all();
-    }
-
-    public function save($optionsData)
-    {
-        $options = $this->getAll();
-        foreach ($optionsData as $key => $value) {
-            $option = $options->where('key', $key)->first();
-            $option->value = $value;
-            $option->save();
-        }
-
-        return 'saved';
-    }
-}

app/Http/Controllers/References/OptionsController.php

@@ -2,67 +2,58 @@
 
 namespace App\Http\Controllers\References;
 
-use App\Http\Requests\Options\CreateRequest;
-use App\Http\Requests\Options\DeleteRequest;
+use App\Entities\Options\Option;
 use App\Http\Controllers\Controller;
-use App\Entities\Options\OptionsRepository;
-
 use Illuminate\Http\Request;
 
-class OptionsController extends Controller {
-
-	private $repo;
-
-	public function __construct(OptionsRepository $repo)
+class OptionsController extends Controller
 {
-	    $this->repo = $repo;
-	}
-
     public function index(Request $req)
     {
+        $options = Option::all();
         $editableOption = null;
-		$options = $this->repo->getAll();
 
-		if (in_array($req->get('action'), ['del','edit']) && $req->has('id'))
-			$editableOption = $this->repo->requireById($req->get('id'));
+        if (in_array($req->get('action'), ['del', 'edit']) && $req->has('id')) {
+            $editableOption = Option::findOrFail($req->get('id'));
+        }
 
         return view('options.index', compact('options', 'editableOption'));
     }
 
-	public function create()
+    public function store(Request $req)
     {
-		return view('options.create');
-	}
+        $newOptionData = $req->validate([
+            'key' => 'required|max:255|alpha_dash',
+            'value' => 'max:255',
+        ]);
+
+        $option = Option::create($newOptionData);
 
-	public function store(CreateRequest $req)
-	{
-		$option = $this->repo->create($req->except('_token'));
         flash()->success(trans('option.created'));
         return redirect()->route('options.index');
     }
 
-	public function delete($optionId)
-	{
-	    $option = $this->repo->requireById($optionId);
-		return view('options.delete', compact('option'));
-	}
-
     public function destroy(Request $req, $optionId)
     {
-		if ($optionId == $req->get('option_id'))
-		{
-			$this->repo->delete($optionId);
+        if ($optionId == $req->get('option_id')) {
+            Option::findOrFail($optionId)->delete();
             flash()->success(trans('option.deleted'));
-		}
-		else
+        } else {
             flash()->error(trans('option.undeleted'));
+        }
 
         return redirect()->route('options.index');
     }
 
     public function save(Request $req)
     {
-		$this->repo->save($req->except(['_method','_token']));
+        $options = Option::all();
+        foreach ($req->except(['_method', '_token']) as $key => $value) {
+            $option = $options->where('key', $key)->first();
+            $option->value = $value;
+            $option->save();
+        }
+
         flash()->success(trans('option.updated'));
         return redirect()->route('options.index');
     }

app/Http/Requests/Options/CreateRequest.php

@@ -1,31 +0,0 @@
-<?php
-
-namespace App\Http\Requests\Options;
-
-use App\Http\Requests\Request;
-
-class CreateRequest extends Request
-{
-    /**
-     * Determine if the user is authorized to make this request.
-     *
-     * @return bool
-     */
-    public function authorize()
-    {
-        return auth()->user()->can('manage_options');
-    }
-
-    /**
-     * Get the validation rules that apply to the request.
-     *
-     * @return array
-     */
-    public function rules()
-    {
-        return [
-            'key'   => 'required|max:255|alpha_dash',
-            'value' => 'max:255',
-        ];
-    }
-}

routes/web/references.php

@@ -5,9 +5,7 @@ Route::group(['namespace' => 'References','middleware'=>['web','role:admin']], f
      * Options Routes
      */
     Route::get('options', ['as' => 'options.index', 'uses' => 'OptionsController@index']);
-    Route::get('options/create', ['as'=>'options.create' , 'uses'=>'OptionsController@create']);
     Route::post('options/store', ['as' => 'options.store', 'uses' => 'OptionsController@store']);
     Route::patch('options/save', ['as' => 'options.save', 'uses' => 'OptionsController@save']);
-    Route::get('options/{id}/delete', ['as'=>'options.delete' , 'uses'=>'OptionsController@delete']);
     Route::delete('options/{optionId}/destroy', ['as' => 'options.destroy', 'uses' => 'OptionsController@destroy']);
 });