Refactor ManageJobsTest class

Change some route name for project jobs routes
Add docblock for some classes

app/Http/Controllers/Api/ProjectsController.php

@@ -6,6 +6,11 @@ use App\Entities\Projects\ProjectsRepository;
 use App\Http\Controllers\Controller;
 use Illuminate\Http\Request;
 
+/**
+ * Projects Controller
+ *
+ * @author Nafies Luthfi <nafiesl@gmail.com>
+ */
 class ProjectsController extends Controller
 {
     private $repo;

app/Http/Controllers/JobsController.php

@@ -4,9 +4,13 @@ namespace App\Http\Controllers;
 
 use App\Entities\Projects\JobsRepository;
 
+/**
+ * Jobs Controller
+ *
+ * @author Nafies Luthfi <nafiesl@gmail.com>
+ */
 class JobsController extends Controller
 {
-
     private $repo;
 
     public function __construct(JobsRepository $repo)

resources/views/jobs/add-from-other-project.blade.php

@@ -23,7 +23,7 @@
                 </div>
                 {!! Form::close() !!}
                 @if ($selectedProject)
-                {!! Form::open(['route'=>['jobs.store-from-other-project', $project->id]]) !!}
+                {!! Form::open(['route' => ['projects.jobs.store-from-other-project', $project->id]]) !!}
                 <ul class="list-unstyled">
                     @forelse($selectedProject->jobs as $key => $job)
                     <li>

resources/views/jobs/create.blade.php

@@ -7,7 +7,7 @@
 
 <div class="row">
     <div class="col-sm-6">
-        {!! Form::open(['route'=>['jobs.store', $project->id]]) !!}
+        {!! Form::open(['route' => ['projects.jobs.store', $project->id]]) !!}
         <div class="panel panel-default">
             <div class="panel-heading"><h3 class="panel-title">{{ trans('job.create') }}</h3></div>
             <div class="panel-body">

routes/web/projects.php

@@ -31,8 +31,8 @@ Route::group(['middleware' => ['web', 'auth'], 'namespace' => 'Projects'], funct
      */
     Route::get('projects/{id}/jobs/create', ['as' => 'jobs.create', 'uses' => 'JobsController@create']);
     Route::get('projects/{id}/jobs/add-from-other-project', ['as' => 'jobs.add-from-other-project', 'uses' => 'JobsController@addFromOtherProject']);
-    Route::post('projects/{id}/jobs', ['as' => 'jobs.store', 'uses' => 'JobsController@store']);
-    Route::post('projects/{id}/jobs/store-from-other-project', ['as' => 'jobs.store-from-other-project', 'uses' => 'JobsController@storeFromOtherProject']);
+    Route::post('projects/{id}/jobs', ['as' => 'projects.jobs.store', 'uses' => 'JobsController@store']);
+    Route::post('projects/{id}/jobs/store-from-other-project', ['as' => 'projects.jobs.store-from-other-project', 'uses' => 'JobsController@storeFromOtherProject']);
     Route::get('jobs/{id}/delete', ['as' => 'jobs.delete', 'uses' => 'JobsController@delete']);
     Route::post('jobs/{id}/tasks-reorder', ['as' => 'jobs.tasks-reorder', 'uses' => 'JobsController@tasksReorder']);
     Route::get('projects/{project}/jobs', ['as' => 'projects.jobs.index', 'uses' => 'JobsController@index']);

tests/Feature/Api/ApiEventsTest.php

@@ -7,6 +7,11 @@ use App\Entities\Users\Event;
 use App\Entities\Users\User;
 use Tests\TestCase;
 
+/**
+ * Manage Events API Feature Test
+ *
+ * @author Nafies Luthfi <nafiesl@gmail.com>
+ */
 class ApiEventsTest extends TestCase
 {
     /** @test */

tests/Feature/Api/ApiManageProjectsTest.php

@@ -5,6 +5,11 @@ namespace Tests\Feature\Api;
 use App\Entities\Projects\Project;
 use Tests\TestCase;
 
+/**
+ * Manage Projects API Feature Test
+ *
+ * @author Nafies Luthfi <nafiesl@gmail.com>
+ */
 class ApiManageProjectsTest extends TestCase
 {
     /** @test */

tests/Feature/ManageJobsTest.php

@@ -154,16 +154,19 @@ class ManageJobsTest extends TestCase
         $this->press(trans('project.show_jobs'));
         $this->seePageIs(route('jobs.add-from-other-project', [$projects[1]->id, 'project_id' => $projects[0]->id]));
 
-        $form = $this->getForm(trans('job.create'));
-        $form['job_ids'][$jobs[0]->id]->tick();
-        $form['job_ids'][$jobs[1]->id]->tick();
-        $form[$jobs[0]->id.'_task_ids'][$tasks1[0]->id]->tick();
-        $form[$jobs[0]->id.'_task_ids'][$tasks1[1]->id]->tick();
-        $form[$jobs[0]->id.'_task_ids'][$tasks1[2]->id]->tick();
-        $form[$jobs[1]->id.'_task_ids'][$tasks2[0]->id]->tick();
-        $form[$jobs[1]->id.'_task_ids'][$tasks2[1]->id]->tick();
-        $form[$jobs[1]->id.'_task_ids'][$tasks2[2]->id]->tick();
-        $this->makeRequestUsingForm($form);
+        $this->submitForm(trans('job.create'), [
+            'job_ids['.$jobs[0]->id.']' => $jobs[0]->id,
+
+            $jobs[0]->id.'_task_ids['.$tasks1[0]->id.']' => $tasks1[0]->id,
+            $jobs[0]->id.'_task_ids['.$tasks1[1]->id.']' => $tasks1[1]->id,
+            $jobs[0]->id.'_task_ids['.$tasks1[2]->id.']' => $tasks1[2]->id,
+
+            'job_ids['.$jobs[1]->id.']' => $jobs[1]->id,
+
+            $jobs[1]->id.'_task_ids['.$tasks2[0]->id.']' => $tasks2[0]->id,
+            $jobs[1]->id.'_task_ids['.$tasks2[1]->id.']' => $tasks2[1]->id,
+            $jobs[1]->id.'_task_ids['.$tasks2[2]->id.']' => $tasks2[2]->id,
+        ]);
 
         $this->seePageIs(route('projects.jobs.index', $projects[1]->id));