Browse Source

Remove limit for UpdateRequest handler rules

pull/42/head
Damilola Olowookere 7 years ago
parent
commit
20e87b1092
  1. 16
      app/Http/Requests/Jobs/UpdateRequest.php
  2. 16
      app/Http/Requests/Projects/UpdateRequest.php
  3. 14
      app/Http/Requests/Tasks/UpdateRequest.php

16
app/Http/Requests/Jobs/UpdateRequest.php

@ -2,8 +2,8 @@
namespace App\Http\Requests\Jobs; namespace App\Http\Requests\Jobs;
use App\Http\Requests\Request;
use App\Entities\Projects\Project; use App\Entities\Projects\Project;
use App\Http\Requests\Request;
class UpdateRequest extends Request class UpdateRequest extends Request
{ {
@ -26,12 +26,22 @@ class UpdateRequest extends Request
*/ */
public function rules() public function rules()
{ {
return [
$rules = [
'name' => 'required|max:60', 'name' => 'required|max:60',
'price' => 'required|numeric', 'price' => 'required|numeric',
'worker_id' => 'required|numeric', 'worker_id' => 'required|numeric',
'type_id' => 'required|numeric', 'type_id' => 'required|numeric',
'description' => 'max:255',
]; ];
//Allow for flexibility instead of optionless hard-coded value for "description". This is
//achieved using environmental variable.
//A value of zero (0) will mean "no limit"
$char_len_job_description = intval(env("CHAR_LEN_JOB_DESCRIPTION", 255));
if ($char_len_job_description > 0) {
$rules["description"] = "max:$char_len_job_description";
}
return $rules;
} }
} }

16
app/Http/Requests/Projects/UpdateRequest.php

@ -2,8 +2,8 @@
namespace App\Http\Requests\Projects; namespace App\Http\Requests\Projects;
use App\Http\Requests\Request;
use App\Entities\Projects\Project; use App\Entities\Projects\Project;
use App\Http\Requests\Request;
class UpdateRequest extends Request class UpdateRequest extends Request
{ {
@ -26,9 +26,8 @@ class UpdateRequest extends Request
*/ */
public function rules() public function rules()
{ {
return [
$rules = [
'name' => 'required|max:50', 'name' => 'required|max:50',
'description' => 'nullable|max:255',
'proposal_date' => 'nullable|date|date_format:Y-m-d', 'proposal_date' => 'nullable|date|date_format:Y-m-d',
'proposal_value' => 'nullable|numeric', 'proposal_value' => 'nullable|numeric',
'start_date' => 'nullable|date|date_format:Y-m-d', 'start_date' => 'nullable|date|date_format:Y-m-d',
@ -38,5 +37,16 @@ class UpdateRequest extends Request
'customer_id' => 'nullable|numeric', 'customer_id' => 'nullable|numeric',
'status_id' => 'required|numeric', 'status_id' => 'required|numeric',
]; ];
//Allow for flexibility instead of optionless hard-coded value for "description". This is
//achieved using environmental variable.
//A value of zero (0) will mean "no limit"
$char_len_project_description = intval(env("CHAR_LEN_PROJECT_DESCRIPTION", 255));
if ($char_len_project_description > 0) {
$rules["description"] = "max:$char_len_project_description";
}
return $rules;
} }
} }

14
app/Http/Requests/Tasks/UpdateRequest.php

@ -25,11 +25,21 @@ class UpdateRequest extends Request
*/ */
public function rules() public function rules()
{ {
return [
$rules = [
'name' => 'required|max:60', 'name' => 'required|max:60',
'description' => 'nullable|max:255',
'progress' => 'required|numeric|max:100', 'progress' => 'required|numeric|max:100',
'job_id' => 'required|numeric|exists:jobs,id', 'job_id' => 'required|numeric|exists:jobs,id',
]; ];
//Allow for flexibility instead of optionless hard-coded value for "description". This is
//achieved using environmental variable.
//A value of zero (0) will mean "no limit"
$char_len_task_description = intval(env("CHAR_LEN_TASK_DESCRIPTION", 255));
if ($char_len_task_description > 0) {
$rules["description"] = "max:$char_len_task_description";
}
return $rules;
} }
} }
Loading…
Cancel
Save