From dfb701c0b5810de8829939328f1409643c6e8727 Mon Sep 17 00:00:00 2001 From: Nafies Luthfi Date: Thu, 2 Nov 2017 22:08:36 +0800 Subject: [PATCH] Change Agency addWorkers to Agency addWorker for single worker --- app/Entities/Agencies/Agency.php | 10 +++++----- tests/Feature/ManageVendorsTest.php | 3 --- tests/Unit/Models/AgencyTest.php | 8 +++++--- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/app/Entities/Agencies/Agency.php b/app/Entities/Agencies/Agency.php index c977529..93d4da2 100644 --- a/app/Entities/Agencies/Agency.php +++ b/app/Entities/Agencies/Agency.php @@ -2,8 +2,8 @@ namespace App\Entities\Agencies; +use App\Entities\Users\User; use Illuminate\Database\Eloquent\Model; -use Illuminate\Support\Collection; class Agency extends Model { @@ -24,13 +24,13 @@ class Agency extends Model return $this->belongsToMany('App\Entities\Users\User', 'agency_workers', 'agency_id', 'worker_id'); } - public function addWorkers(Collection $workers) + public function addWorker(User $worker) { - $this->workers()->attach($workers); + $this->workers()->attach($worker); } - public function removeWorkers(Collection $workers) + public function removeWorker(User $worker) { - $this->workers()->detach($workers); + $this->workers()->detach($worker); } } diff --git a/tests/Feature/ManageVendorsTest.php b/tests/Feature/ManageVendorsTest.php index 4a04395..c565e58 100644 --- a/tests/Feature/ManageVendorsTest.php +++ b/tests/Feature/ManageVendorsTest.php @@ -3,13 +3,10 @@ namespace Tests\Feature; use App\Entities\Partners\Vendor; -use Illuminate\Foundation\Testing\DatabaseMigrations; use Tests\TestCase as TestCase; class ManageVendorsTest extends TestCase { - use DatabaseMigrations; - /** @test */ public function user_can_see_vendor_list_in_vendor_index_page() { diff --git a/tests/Unit/Models/AgencyTest.php b/tests/Unit/Models/AgencyTest.php index 6e22027..0e1c1a1 100644 --- a/tests/Unit/Models/AgencyTest.php +++ b/tests/Unit/Models/AgencyTest.php @@ -33,7 +33,8 @@ class AgencyTest extends TestCase $agency = factory(Agency::class)->create(); $workers = factory(User::class, 2)->create(); - $agency->addWorkers($workers); + $agency->addWorker($workers[0]); + $agency->addWorker($workers[1]); $this->assertCount(2, $agency->workers); $this->assertInstanceOf(Collection::class, $agency->workers); @@ -46,11 +47,12 @@ class AgencyTest extends TestCase $agency = factory(Agency::class)->create(); $workers = factory(User::class, 2)->create(); - $agency->addWorkers($workers); + $agency->addWorker($workers[0]); + $agency->addWorker($workers[1]); $this->assertCount(2, $agency->workers); - $agency->removeWorkers($workers->take(1)); + $agency->removeWorker($workers[0]); $agency = $agency->fresh(); $this->assertCount(1, $agency->workers);