From 96cd04fac2d4c04bc2ef7c73bb12f99cae7d4aae Mon Sep 17 00:00:00 2001
From: Nafies Luthfi <nafiesl@gmail.com>
Date: Wed, 9 Jan 2019 20:38:37 +0800
Subject: [PATCH] [wip] Refactor log file viewer routes to controller

Add Reports\LogFileController@index
---
 app/Http/Controllers/Reports/LogFileController.php | 24 ++++++++++++++++++++++
 routes/web/reports.php                             | 15 +-------------
 2 files changed, 25 insertions(+), 14 deletions(-)
 create mode 100644 app/Http/Controllers/Reports/LogFileController.php

diff --git a/app/Http/Controllers/Reports/LogFileController.php b/app/Http/Controllers/Reports/LogFileController.php
new file mode 100644
index 0000000..f42ddb7
--- /dev/null
+++ b/app/Http/Controllers/Reports/LogFileController.php
@@ -0,0 +1,24 @@
+<?php
+
+namespace App\Http\Controllers\Reports;
+
+use App\Http\Controllers\Controller;
+
+class LogFileController extends Controller
+{
+    public function index()
+    {
+        if (!file_exists(storage_path('logs'))) {
+            return [];
+        }
+
+        $logFiles = \File::allFiles(storage_path('logs'));
+
+        // Sort files by modified time DESC
+        usort($logFiles, function ($a, $b) {
+            return -1 * strcmp($a->getMTime(), $b->getMTime());
+        });
+
+        return view('reports.log-files', compact('logFiles'));
+    }
+}
diff --git a/routes/web/reports.php b/routes/web/reports.php
index 2d4d867..33d4aea 100644
--- a/routes/web/reports.php
+++ b/routes/web/reports.php
@@ -10,20 +10,7 @@ Route::group(['middleware' => ['web', 'role:admin'], 'prefix' => 'reports'], fun
     Route::get('payments/yearly', ['as' => 'reports.payments.yearly', 'uses' => 'ReportsController@yearly']);
     Route::get('current-credits', ['as' => 'reports.current-credits', 'uses' => 'ReportsController@currentCredits']);
 
-    Route::get('log-files', ['as' => 'log-files.index', 'uses' => function () {
-        if (!file_exists(storage_path('logs'))) {
-            return [];
-        }
-
-        $logFiles = \File::allFiles(storage_path('logs'));
-
-        // Sort files by modified time DESC
-        usort($logFiles, function ($a, $b) {
-            return -1 * strcmp($a->getMTime(), $b->getMTime());
-        });
-
-        return view('reports.log-files', compact('logFiles'));
-    }]);
+    Route::get('log-files', ['as' => 'log-files.index', 'uses' => 'Reports\LogFileController@index']);
 
     Route::get('log-files/{filename}', ['as' => 'log-files.show', 'uses' => function ($fileName) {
         if (file_exists(storage_path('logs/'.$fileName))) {