From 7380f3f5a909e0298d037a493460a24e58d8075a Mon Sep 17 00:00:00 2001 From: Nafies Luthfi Date: Sat, 16 Feb 2019 21:43:57 +0800 Subject: [PATCH] Move getVendorsList method call to parent controller --- app/Entities/BaseRepository.php | 12 ------------ app/Http/Controllers/PaymentsController.php | 2 +- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/app/Entities/BaseRepository.php b/app/Entities/BaseRepository.php index c513d86..bc37764 100755 --- a/app/Entities/BaseRepository.php +++ b/app/Entities/BaseRepository.php @@ -53,18 +53,6 @@ abstract class BaseRepository extends EloquentRepository } /** - * Get collection of vendors. - * - * @return \Illuminate\Database\Eloquent\Collection - */ - public function getVendorsList() - { - return Vendor::where('is_active', 1) - ->orderBy('name') - ->pluck('name', 'id'); - } - - /** * Get Job by it's id. * * @param int $jobId diff --git a/app/Http/Controllers/PaymentsController.php b/app/Http/Controllers/PaymentsController.php index 325932d..1ad1c4e 100755 --- a/app/Http/Controllers/PaymentsController.php +++ b/app/Http/Controllers/PaymentsController.php @@ -101,7 +101,7 @@ class PaymentsController extends Controller } elseif ($payment->partner_type == 'App\Entities\Partners\Customer') { $partners = [__('customer.customer') => $this->repo->getCustomersList()]; } else { - $partners = [__('vendor.vendor') => $this->repo->getVendorsList()]; + $partners = [__('vendor.vendor') => $this->getVendorsList()]; } return view('payments.edit', compact('payment', 'projects', 'partners'));