From 504ade55318f7385c09f77759c2ea77d3fdbb4ec Mon Sep 17 00:00:00 2001 From: Nafies Luthfi Date: Wed, 31 Oct 2018 08:32:34 +0800 Subject: [PATCH] Update bank account controller docblocks --- .../References/BankAccountsController.php | 22 +++++++++------------- .../Feature/References/ManageBankAccountsTest.php | 10 ++++++++-- 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/app/Http/Controllers/References/BankAccountsController.php b/app/Http/Controllers/References/BankAccountsController.php index f75dc29..a95f966 100644 --- a/app/Http/Controllers/References/BankAccountsController.php +++ b/app/Http/Controllers/References/BankAccountsController.php @@ -14,9 +14,9 @@ use App\Entities\Invoices\BankAccount; class BankAccountsController extends Controller { /** - * Display a listing of the bankAccount. + * Display a listing of the bank account. * - * @return \Illuminate\Http\Response + * @return \Illuminate\View\View */ public function index() { @@ -33,9 +33,8 @@ class BankAccountsController extends Controller /** * Store a newly created bank account in storage. * - * @param \Illuminate\Http\Request $request - * - * @return \Illuminate\Http\Response + * @param \Illuminate\Http\Request $request + * @return \Illuminate\Http\RedirectResponse */ public function store(Request $request) { @@ -56,10 +55,9 @@ class BankAccountsController extends Controller /** * Update the specified bank account in storage. * - * @param \Illuminate\Http\Request $request - * @param \App\Entities\Invoices\BankAccount $bankAccount - * - * @return \Illuminate\Http\Response + * @param \Illuminate\Http\Request $request + * @param \App\Entities\Invoices\BankAccount $bankAccount + * @return \Illuminate\Http\RedirectResponse */ public function update(Request $request, BankAccount $bankAccount) { @@ -80,9 +78,8 @@ class BankAccountsController extends Controller /** * Remove the specified bank account from storage. * - * @param \App\Entities\Invoices\BankAccount $bankAccount - * - * @return \Illuminate\Http\Response + * @param \App\Entities\Invoices\BankAccount $bankAccount + * @return \Illuminate\Http\RedirectResponse */ public function destroy(BankAccount $bankAccount) { @@ -91,7 +88,6 @@ class BankAccountsController extends Controller ]); if (request('bank_account_id') == $bankAccount->id && $bankAccount->delete()) { - flash(trans('bank_account.deleted'), 'success'); return redirect()->route('bank-accounts.index'); diff --git a/tests/Feature/References/ManageBankAccountsTest.php b/tests/Feature/References/ManageBankAccountsTest.php index e79af46..bef5f49 100644 --- a/tests/Feature/References/ManageBankAccountsTest.php +++ b/tests/Feature/References/ManageBankAccountsTest.php @@ -60,7 +60,10 @@ class ManageBankAccountsTest extends TestCase $this->visit(route('bank-accounts.index')); $this->click('edit-bank_account-1'); - $this->seePageIs(route('bank-accounts.index', ['action' => 'edit', 'id' => $bankAccount->id])); + + $this->seePageIs(route('bank-accounts.index', [ + 'action' => 'edit', 'id' => $bankAccount->id, + ])); $this->submitForm(__('bank_account.update'), [ 'name' => 'BankAccount 2 name', @@ -88,7 +91,10 @@ class ManageBankAccountsTest extends TestCase $this->visit(route('bank-accounts.index')); $this->click('del-bank_account-'.$bankAccount->id); - $this->seePageIs(route('bank-accounts.index', ['action' => 'delete', 'id' => $bankAccount->id])); + + $this->seePageIs(route('bank-accounts.index', [ + 'action' => 'delete', 'id' => $bankAccount->id, + ])); $this->press(__('app.delete_confirm_button'));