From 22b63a6e8f0d0c96c0e9f4e1b216b90d99ecf4cf Mon Sep 17 00:00:00 2001
From: Nafies Luthfi <nafiesl@gmail.com>
Date: Fri, 23 Feb 2018 08:19:28 +0800
Subject: [PATCH] Update job policy for see job pricings

---
 app/Policies/Projects/JobPolicy.php              | 13 +++++++++++++
 resources/views/jobs/partials/job-show.blade.php |  2 +-
 resources/views/jobs/unfinished.blade.php        | 12 +++++++-----
 tests/Unit/Policies/JobPolicyTest.php            | 11 +++++++++++
 4 files changed, 32 insertions(+), 6 deletions(-)

diff --git a/app/Policies/Projects/JobPolicy.php b/app/Policies/Projects/JobPolicy.php
index 08a0e51..b5262d9 100644
--- a/app/Policies/Projects/JobPolicy.php
+++ b/app/Policies/Projects/JobPolicy.php
@@ -67,4 +67,17 @@ class JobPolicy
     {
         return $user->hasRole('admin');
     }
+
+    /**
+     * Determine whether the user can see job pricings.
+     *
+     * @param \App\Entities\Users\User   $user
+     * @param \App\Entities\Projects\Job $job
+     *
+     * @return mixed
+     */
+    public function seePricings(User $user, Job $job)
+    {
+        return $user->hasRole('admin');
+    }
 }
diff --git a/resources/views/jobs/partials/job-show.blade.php b/resources/views/jobs/partials/job-show.blade.php
index 811b548..aceee15 100644
--- a/resources/views/jobs/partials/job-show.blade.php
+++ b/resources/views/jobs/partials/job-show.blade.php
@@ -4,7 +4,7 @@
         <tbody>
             <tr><th class="col-md-4">{{ trans('job.name') }}</th><td class="col-md-8">{{ $job->name }}</td></tr>
             <tr><th>{{ trans('job.type') }}</th><td>{{ $job->type() }}</td></tr>
-            @can('see-pricings', $job->project)
+            @can('see-pricings', $job)
             <tr><th>{{ trans('job.price') }}</th><td>{{ formatRp($job->price) }}</td></tr>
             @endcan
             <tr><th>{{ trans('job.progress') }}</th><td>{{ formatDecimal($job->tasks->avg('progress')) }}%</td></tr>
diff --git a/resources/views/jobs/unfinished.blade.php b/resources/views/jobs/unfinished.blade.php
index df5c0d0..10962ce 100755
--- a/resources/views/jobs/unfinished.blade.php
+++ b/resources/views/jobs/unfinished.blade.php
@@ -13,9 +13,9 @@
             <th>{{ trans('job.name') }}</th>
             <th class="text-center">{{ trans('job.tasks_count') }}</th>
             <th class="text-center">{{ trans('job.progress') }}</th>
-            @if(auth()->user()->hasRole('admin'))
+            @can('see-pricings', new App\Entities\Projects\Job)
             <th class="text-right">{{ trans('job.price') }}</th>
-            @endauth
+            @endcan
             <th>{{ trans('job.worker') }}</th>
             <th>{{ trans('app.action') }}</th>
         </thead>
@@ -39,16 +39,16 @@
                 </td>
                 <td class="text-center">{{ $job->tasks_count = $job->tasks->count() }}</td>
                 <td class="text-center">{{ formatDecimal($job->progress) }} %</td>
-                @if(auth()->user()->hasRole('admin'))
+                @can('see-pricings', $job)
                 <td class="text-right">{{ formatRp($job->price) }}</td>
-                @endif
+                @endcan
                 <td>{{ $job->worker->name }}</td>
                 <td>
                     {!! link_to_route('jobs.show', trans('app.show'),[$job->id],['class' => 'btn btn-info btn-xs']) !!}
                 </td>
             </tr>
             @empty
-            <tr><td colspan="7">{{ trans('job.empty') }}</td></tr>
+            <tr><td colspan="8">{{ trans('job.empty') }}</td></tr>
             @endforelse
         </tbody>
         <tfoot>
@@ -56,7 +56,9 @@
                 <th class="text-right" colspan="3">Total</th>
                 <th class="text-center">{{ $jobs->sum('tasks_count') }}</th>
                 <th class="text-center">{{ formatDecimal($jobs->avg('progress')) }} %</th>
+                @can('see-pricings', new App\Entities\Projects\Job)
                 <th class="text-right">{{ formatRp($jobs->sum('price')) }}</th>
+                @endcan
                 <th colspan="2"></th>
             </tr>
         </tfoot>
diff --git a/tests/Unit/Policies/JobPolicyTest.php b/tests/Unit/Policies/JobPolicyTest.php
index 3650d95..6b985a1 100644
--- a/tests/Unit/Policies/JobPolicyTest.php
+++ b/tests/Unit/Policies/JobPolicyTest.php
@@ -70,4 +70,15 @@ class JobPolicyTest extends TestCase
         $this->assertTrue($admin->can('update', $job));
         $this->assertFalse($worker->can('update', $job));
     }
+
+    /** @test */
+    public function only_admin_can_see_job_pricings()
+    {
+        $admin = $this->createUser('admin');
+        $worker = $this->createUser('worker');
+        $job = factory(Job::class)->create(['worker_id' => $worker->id]);
+
+        $this->assertTrue($admin->can('see-pricings', $job));
+        $this->assertFalse($worker->can('see-pricings', $job));
+    }
 }